Skip to content

Conversation

@acjh
Copy link
Contributor

@acjh acjh commented May 16, 2018

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [x] Documentation update

Resolves #84
Resolves #216

What is the rationale for this request?

Provide an example for usage of checkboxes and radio buttons with Question component.

What changes did you make? (Give an overview)

  • Document question body syntax in a new Examples page
  • Create hierarchy in header.md (navbar) and userGuideSections.md (sections at bottom of pages)
  • Update links in User Guide

Provide some example code that this change will affect:

-

Is there anything you'd like reviewers to focus on?

Phrasing, grammar and verbosity.

Testing instructions:

Check that the example and the links (navbar, sections) on the Netlify preview work as expected.

<li><a href="{{baseUrl}}/userGuide/includingContents.html">Including Contents</a></li>
<li><a href="{{baseUrl}}/userGuide/siteConfiguration.html">Site Configuration</a></li>
<li><a href="{{baseUrl}}/userGuide/netlifyPreview.html">Preview site on Netlify</a></li>
<li><a href="{{baseUrl}}/userGuide/includingContents.html">Content Authoring — Including Contents</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way, it looks like a sub-menu item.
Content Authoring — Including Contents -> — Including Contents?

<li><a href="{{baseUrl}}/userGuide/siteConfiguration.html">Site Configuration</a></li>
<li><a href="{{baseUrl}}/userGuide/netlifyPreview.html">Preview site on Netlify</a></li>
<li><a href="{{baseUrl}}/userGuide/includingContents.html">Content Authoring — Including Contents</a></li>
<li><a href="{{baseUrl}}/userGuide/contentAuthoringExamples.html">Content Authoring — Examples</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to mix examples together with the descriptions?


<div slot="hint">
Probably yes
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add a blank line here, would it add some separation between hint and answer? It doesn't look nice when the two are stuck together.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, because of the way Vue components work. I can do some styling in Question component.

docs/site.json Outdated
"src": "userGuide/siteConfiguration.md",
"title": "MarkBind: User Guide - Site Configuration"
"src": "userGuide/ghpagesDeployment.md",
"title": "MarkBind: User Guide - Github Pages Deploment"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Deployment


## Question body syntax

MarkBind allows for the easy use of checkboxes and radio buttons with the Question and Panel components in [VueStrap modified by MarkBind](https://markbind.github.io/vue-strap/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"MarkBind allows for the easy use of using checkboxes and radio buttons with..."

@acjh
Copy link
Contributor Author

acjh commented May 16, 2018

This way, it looks like a sub-menu item.
Content Authoring — Including Contents -> — Including Contents?

Used white bullet (◦) and added separators.

Before After

Tried to support sub-menu items (#212) but couldn't handle hover elegantly:

Expectation Reality

@acjh
Copy link
Contributor Author

acjh commented May 16, 2018

Moved the example to contentauthoring#use-components.

<br><br>

```html
<panel header=":lock::key: Does MarkBind allow for the use of checkboxes and radio buttons?">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a good idea to put the sample source code inside the answer slot? They might miss it if they do not expand the answer slot.

@acjh acjh force-pushed the 84-document-question-body-syntax branch from 8464109 to 32a1910 Compare May 18, 2018 05:50
@acjh acjh merged commit 718d5ed into MarkBind:master May 18, 2018
@acjh acjh added this to the v1.7.4 milestone May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken link within User Guide Document question body syntax

3 participants